qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 04/19] include/qom/cpu.h: Add new get_phys_pa


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH v2 04/19] include/qom/cpu.h: Add new get_phys_page_attrs_debug method
Date: Mon, 16 Nov 2015 15:22:13 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

Am 16.11.2015 um 15:07 schrieb Andreas Färber:
> Am 16.11.2015 um 15:05 schrieb Peter Maydell:
>> Add a new optional method get_phys_page_attrs_debug to CPUClass.
>> This is like the existing get_phys_page_debug, but also returns
>> the memory transaction attributes to use for the access.
>> This will be necessary for CPUs which have multiple address
>> spaces and use the attributes to select the correct address
>> space.
>>
>> We provide a wrapper function cpu_get_phys_page_attrs_debug()
>> which falls back to the existing get_phys_page_debug(), so we
>> don't need to change every target CPU.
>>
>> Signed-off-by: Peter Maydell <address@hidden>
>> ---
>>  include/qom/cpu.h | 36 ++++++++++++++++++++++++++++++++++--
>>  1 file changed, 34 insertions(+), 2 deletions(-)
> 
> Please use "qom:" and () by convention, otherwise looks fine.

Err, obviously I meant "cpu:".

> 
> Regards,
> Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]