[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_c
From: |
John Snow |
Subject: |
Re: [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close() |
Date: |
Fri, 13 Nov 2015 17:49:58 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 11/12/2015 01:23 AM, Fam Zheng wrote:
> On Mon, 11/09 23:39, Max Reitz wrote:
>> bdrv_delete() is not very happy about deleting BlockDriverStates with
>> dirty bitmaps still attached to them. In the past, we got around that
>> very easily by relying on bdrv_close_all() bypassing bdrv_delete(), and
>> bdrv_close() simply ignoring that condition. We should fix that by
>> releasing all dirty bitmaps in bdrv_close() and drop the assertion in
>> bdrv_delete().
>
> What bitmaps are attached when bdrv_close() is called? The ones created from
> the monitor should probably be removed by the monitor, and the internal ones
> like in migration and block jobs should probably be removed by stopping the
> respective job.
>
> Fam
>
Well in this case at least it appears we are still asserting that the
BDS has no job attached, so it shouldn't have any internal bitmaps
weighing it down, which just leaves the ones created by the QMP interface.
How important is it that we ask the user to remove all of those bitmaps
themselves?
It might become more important in the future when persistence is an
option and we go to close a transient bitmap -- but persistent bitmaps I
am sure it will be safe to just close out and flush to disk.
--js
- Re: [Qemu-devel] [PATCH v7 01/24] blockdev: Add missing bdrv_unref() in drive-backup, (continued)
- [Qemu-devel] [PATCH v7 02/24] blockjob: Call bdrv_unref() on creation error, Max Reitz, 2015/11/09
- [Qemu-devel] [PATCH v7 04/24] iotests: Rename filter_nbd to _filter_nbd in 083, Max Reitz, 2015/11/09
- [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(), Max Reitz, 2015/11/09
- Re: [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(), John Snow, 2015/11/11
- Re: [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(), Fam Zheng, 2015/11/12
- Re: [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(),
John Snow <=
- Re: [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(), Fam Zheng, 2015/11/16
- Re: [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(), John Snow, 2015/11/16
- Re: [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close(), Fam Zheng, 2015/11/16
- [Qemu-devel] Closing Bitmaps (Was: Re: [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close()), John Snow, 2015/11/17
- Re: [Qemu-devel] Closing Bitmaps (Was: Re: [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close()), Fam Zheng, 2015/11/17
- Re: [Qemu-devel] Closing Bitmaps (Was: Re: [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close()), John Snow, 2015/11/18
- Re: [Qemu-devel] Closing Bitmaps (Was: Re: [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close()), Kevin Wolf, 2015/11/18
- Re: [Qemu-devel] Closing Bitmaps (Was: Re: [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close()), John Snow, 2015/11/18
[Qemu-devel] [PATCH v7 05/24] iotests: Change coding style of _filter_nbd in 083, Max Reitz, 2015/11/09