[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH QEMU 2/2] xen: fix usage of xc_domain_create in
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PATCH QEMU 2/2] xen: fix usage of xc_domain_create in domain builder |
Date: |
Fri, 13 Nov 2015 11:09:43 +0000 |
User-agent: |
Alpine 2.02 (DEB 1266 2009-07-14) |
On Fri, 13 Nov 2015, Roger Pau Monne wrote:
> Due to the addition of HVMlite and the requirement to always provide a valid
> xc_domain_configuration_t, xc_domain_create now always takes an arch domain
> config, which can be NULL in order to mimic previous behaviour.
>
> Signed-off-by: Roger Pau Monné <address@hidden>
Give a look at include/hw/xen/xen_common.h and add a compatibility shim
there. Keep in mind that QEMU needs to build against any version of Xen
from 4.0 onward.
> Cc: Stefano Stabellini <address@hidden>
> Cc: address@hidden
> ---
> hw/xenpv/xen_domainbuild.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/xenpv/xen_domainbuild.c b/hw/xenpv/xen_domainbuild.c
> index c0ab753..a737908 100644
> --- a/hw/xenpv/xen_domainbuild.c
> +++ b/hw/xenpv/xen_domainbuild.c
> @@ -234,7 +234,7 @@ int xen_domain_build_pv(const char *kernel, const char
> *ramdisk,
> int rc;
>
> memcpy(uuid, qemu_uuid, sizeof(uuid));
> - rc = xc_domain_create(xen_xc, ssidref, uuid, flags, &xen_domid);
> + rc = xc_domain_create(xen_xc, ssidref, uuid, flags, &xen_domid, NULL);
> if (rc < 0) {
> fprintf(stderr, "xen: xc_domain_create() failed\n");
> goto err;
> --
> 1.9.5 (Apple Git-50.3)
>