[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/3] block/gluster: rename [server, volname,
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/3] block/gluster: rename [server, volname, image] -> [host, volume, path] |
Date: |
Tue, 10 Nov 2015 08:28:42 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 11/10/2015 02:09 AM, Prasanna Kumar Kalever wrote:
> this patch is very much be meaningful after next patch which adds multiple
> gluster servers support. After that,
>
> an example is, in 'servers' tuple values we use 'server' variable for key
> 'host' in the code, it will be quite messy to have colliding names for
> variables, so to maintain better readability and makes it consistent with
> other
> existing code as well as the input keys/options, this patch renames the
> following variables
> 'server' -> 'host'
> 'image' -> 'path'
> 'volname' -> 'volume'
>
> Signed-off-by: Prasanna Kumar Kalever <address@hidden>
> ---
> block/gluster.c | 54 +++++++++++++++++++++++++++---------------------------
> 1 file changed, 27 insertions(+), 27 deletions(-)
When this has been previously positively reviewed, and you are making no
further changes to the code, it speeds up review to add the reviewer's
line to your commit message (so that the reviewer knows it is unchanged,
and so that other readers know it has been reviewed at least once). Of
course, if you change a patch, dropping the R-b line is appropriate.
My review from
https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg04916.html
still stands, so that would mean adding:
Reviewed-by: Eric Blake <address@hidden>
to the commit body if you have a reason to post v14 of this series.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/3] block/gluster: add support for multiple gluster servers, Prasanna Kumar Kalever, 2015/11/09
- [Qemu-devel] [PATCH 0/3] block/gluster: add support for multiple gluster servers, Prasanna Kumar Kalever, 2015/11/10
- [Qemu-devel] [PATCH v2 1/3] block/gluster: rename [server, volname, image] -> [host, volume, path], Prasanna Kumar Kalever, 2015/11/10
- Re: [Qemu-devel] [PATCH v2 1/3] block/gluster: rename [server, volname, image] -> [host, volume, path],
Eric Blake <=
- [Qemu-devel] [PATCH v2 2/3] block/gluster: code cleanup, Prasanna Kumar Kalever, 2015/11/10
- [Qemu-devel] [PATCH v13 3/3] block/gluster: add support for multiple gluster servers, Prasanna Kumar Kalever, 2015/11/10
- Re: [Qemu-devel] [PATCH v13 3/3] block/gluster: add support for multiple gluster servers, Eric Blake, 2015/11/10
- Re: [Qemu-devel] [PATCH v13 3/3] block/gluster: add support for multiple gluster servers, Jeff Cody, 2015/11/10
- Re: [Qemu-devel] [PATCH v13 3/3] block/gluster: add support for multiple gluster servers, Prasanna Kumar Kalever, 2015/11/12
- Re: [Qemu-devel] [PATCH v13 3/3] block/gluster: add support for multiple gluster servers, Jeff Cody, 2015/11/12
- Re: [Qemu-devel] [PATCH v13 3/3] block/gluster: add support for multiple gluster servers, Jeff Cody, 2015/11/12
- Re: [Qemu-devel] [PATCH v13 3/3] block/gluster: add support for multiple gluster servers, Jeff Cody, 2015/11/10
- Re: [Qemu-devel] [PATCH v13 3/3] block/gluster: add support for multiple gluster servers, Prasanna Kumar Kalever, 2015/11/12
Re: [Qemu-devel] [PATCH 0/3] block/gluster: add support for multiple gluster servers, Eric Blake, 2015/11/10