[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/10] snapshot: create bdrv_all_find_snapshot h
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 05/10] snapshot: create bdrv_all_find_snapshot helper |
Date: |
Mon, 9 Nov 2015 17:27:22 +0000 |
User-agent: |
Mutt/1.5.23 (2015-06-09) |
On Sat, Nov 07, 2015 at 06:54:55PM +0300, Denis V. Lunev wrote:
This:
> +int bdrv_all_find_snapshot(const char *name, BlockDriverState **first_bad_bs)
> +{
> + QEMUSnapshotInfo sn;
> + int err = 0;
> + BlockDriverState *bs = NULL;
> +
> + while (err == 0 && (bs = bdrv_next(bs))) {
> + AioContext *ctx = bdrv_get_aio_context(bs);
> +
> + aio_context_acquire(ctx);
> + if (bdrv_is_inserted(bs) && !bdrv_is_read_only(bs)) {
> + err = bdrv_snapshot_find(bs, &sn, name);
> + }
> + aio_context_release(ctx);
> + }
> +
> + *first_bad_bs = bs;
> + return err;
> +}
and this:
> @@ -1500,21 +1489,7 @@ void hmp_info_snapshots(Monitor *mon, const QDict
> *qdict)
> available_snapshots = g_new0(int, nb_sns);
> total = 0;
> for (i = 0; i < nb_sns; i++) {
> - sn = &sn_tab[i];
> - available = 1;
> - bs1 = NULL;
> -
> - while ((bs1 = bdrv_next(bs1))) {
> - if (bdrv_can_snapshot(bs1) && bs1 != bs) {
> - ret = bdrv_snapshot_find(bs1, sn_info, sn->id_str);
> - if (ret < 0) {
> - available = 0;
> - break;
> - }
> - }
> - }
> -
> - if (available) {
> + if (bdrv_all_find_snapshot(sn_tab[i].id_str, &bs1) == 0) {
> available_snapshots[total] = i;
> total++;
> }
is not equivalent. hmp_info_snapshots() skips devices that are inserted
and writeable but do not support snapshots. The new code will fail in
that case.
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH for 2.5 v6 0/10] dataplane snapshot fixes, Denis V. Lunev, 2015/11/07
- [Qemu-devel] [PATCH 01/10] snapshot: create helper to test that block drivers supports snapshots, Denis V. Lunev, 2015/11/07
- [Qemu-devel] [PATCH 03/10] snapshot: create bdrv_all_delete_snapshot helper, Denis V. Lunev, 2015/11/07
- [Qemu-devel] [PATCH 05/10] snapshot: create bdrv_all_find_snapshot helper, Denis V. Lunev, 2015/11/07
- Re: [Qemu-devel] [PATCH 05/10] snapshot: create bdrv_all_find_snapshot helper,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 06/10] migration: drop find_vmstate_bs check in hmp_delvm, Denis V. Lunev, 2015/11/07
- [Qemu-devel] [PATCH 02/10] snapshot: return error code from bdrv_snapshot_delete_by_id_or_name, Denis V. Lunev, 2015/11/07
- [Qemu-devel] [PATCH 04/10] snapshot: create bdrv_all_goto_snapshot helper, Denis V. Lunev, 2015/11/07
- [Qemu-devel] [PATCH 07/10] snapshot: create bdrv_all_create_snapshot helper, Denis V. Lunev, 2015/11/07
- [Qemu-devel] [PATCH 09/10] migration: implement bdrv_all_find_vmstate_bs helper, Denis V. Lunev, 2015/11/07
- [Qemu-devel] [PATCH 10/10] migration: normalize locking in migration/savevm.c, Denis V. Lunev, 2015/11/07
- [Qemu-devel] [PATCH 08/10] migration: reorder processing in hmp_savevm, Denis V. Lunev, 2015/11/07
- Re: [Qemu-devel] [PATCH for 2.5 v6 0/10] dataplane snapshot fixes, Stefan Hajnoczi, 2015/11/09