[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 for-2.6 00/15] block: Rework bdrv_close_all()
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v6 for-2.6 00/15] block: Rework bdrv_close_all() |
Date: |
Mon, 9 Nov 2015 17:03:59 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 04.11.2015 um 19:57 hat Max Reitz geschrieben:
> Currently, bdrv_close_all() force-closes all BDSs with a BlockBackend,
> which can lead to data corruption (see the iotest added in the final
> patch of this series) and is most certainly very ugly.
>
> This series reworks bdrv_close_all() to instead eject the BDS trees from
> all BlockBackends and then close the monitor-owned BDS trees, which are
> the only BDSs without a BB. In effect, all BDSs are closed just by
> getting closed automatically due to their reference count becoming 0.
>
> Note that the approach taken here leaks all BlockBackends. This does not
> really matter, however, since qemu is about to exit anyway.
Patches 1-2, 5-6, 8-15:
Reviewed-by: Kevin Wolf <address@hidden>
- Re: [Qemu-devel] [PATCH v6 12/15] blockdev: Keep track of monitor-owned BDS, (continued)
[Qemu-devel] [PATCH v6 15/15] iotests: Add test for multiple BB on BDS tree, Max Reitz, 2015/11/04
Re: [Qemu-devel] [PATCH v6 for-2.6 00/15] block: Rework bdrv_close_all(),
Kevin Wolf <=