Re: [Qemu-devel] virtio-gpu doesn't build if you do a linux-headers update from kvm/next

[Paolo Bonzini]

On 05/11/2015 12:42, Peter Maydell wrote:
> I tried to do a linux headers update against kvm/next (commit
> 197a4f4b063e4) with update-linux-headers.sh, but the result gives
> a virtio-gpu that doesn't compile:
> 
> make: Entering directory
> `/home/petmay01/linaro/qemu-from-laptop/qemu/build/all-debug'
>   CC    aarch64-softmmu/hw/display/virtio-gpu.o
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/display/virtio-gpu.c:
> In function ‘virtio_gpu_get_features’:
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/display/virtio-gpu.c:149:27:
> error: ‘VIRTIO_GPU_FEATURE_VIRGL’ undeclared (first use in this
> function)
>          features |= (1 << VIRTIO_GPU_FEATURE_VIRGL);
>                            ^
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/display/virtio-gpu.c:149:27:
> note: each undeclared identifier is reported only once for each
> function it appears in
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/display/virtio-gpu.c:
> In function ‘virtio_gpu_set_features’:
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/display/virtio-gpu.c:156:41:
> error: ‘VIRTIO_GPU_FEATURE_VIRGL’ undeclared (first use in this
> function)
>      static const uint32_t virgl = (1 << VIRTIO_GPU_FEATURE_VIRGL);
>                                          ^
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/display/virtio-gpu.c:
> In function ‘virtio_gpu_device_realize’:
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/display/virtio-gpu.c:914:25:
> error: ‘struct virtio_gpu_config’ has no member named ‘num_capsets’
>          g->virtio_config.num_capsets = 1;
>                          ^
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/display/virtio-gpu.c:
> At top level:
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/display/virtio-gpu.c:1035:46:
> error: invalid application of ‘sizeof’ to incomplete type ‘struct
> virtio_gpu_transfer_host_3d’
>  QEMU_BUILD_BUG_ON(sizeof(struct virtio_gpu_transfer_host_3d)        != 72);
>                                               ^
> 
> etc, because all the virtio_gpu definitions disappear from
> include/standard-headers/linux/virtio_gpu.h.
> 
> What's happening here?

My guess: these will get into Linus's tree in a few days, and the update
was done on a maintainer tree.

Paolo