Re: [Qemu-devel] [PATCH v9 17/27] qapi: Clean up after previous commit

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> From: Markus Armbruster <address@hidden>
>
> QAPISchemaObjectTypeVariants.check() parameter members is no
> longer used, drop it.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> Message-Id: <address@hidden>
> [Variant.check(seen) is used after all, so reword and reduce scope
> of this patch; rearrange later in the series]

Don't you need to update the subject?  My "previous commit" was "qapi:
Simplify QAPISchemaObjectTypeMember.check()", while yours is "qapi:
Eliminate QAPISchemaObjectType.check() variable members".

Not sure what moving my two patches apart buys you :)

> Signed-off-by: Eric Blake <address@hidden>
>
> ---
> v9: new patch
> ---
>  scripts/qapi.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/qapi.py b/scripts/qapi.py
> index 4019389..3af5edb 100644
> --- a/scripts/qapi.py
> +++ b/scripts/qapi.py
> @@ -991,7 +991,7 @@ class QAPISchemaObjectType(QAPISchemaType):
>              assert m.name not in seen
>              seen[m.name] = m
>          if self.variants:
> -            self.variants.check(schema, [], seen)
> +            self.variants.check(schema, seen)
>          self.members = seen.values()
>
>      def is_implicit(self):
> @@ -1046,7 +1046,7 @@ class QAPISchemaObjectTypeVariants(object):
>          self.tag_member = tag_member
>          self.variants = variants
>
> -    def check(self, schema, members, seen):
> +    def check(self, schema, seen):
>          # seen is non-empty for unions, empty for alternates
>          if self.tag_name:    # flat union
>              self.tag_member = seen[self.tag_name]
> @@ -1086,7 +1086,7 @@ class QAPISchemaAlternateType(QAPISchemaType):
>
>      def check(self, schema):
>          self.variants.tag_member.check(schema)
> -        self.variants.check(schema, [], {})
> +        self.variants.check(schema, {})
>
>      def json_type(self):
>          return 'value'