Re: [Qemu-devel] [PATCH v3 00/11] vl.c: Error message rework

[Markus Armbruster]

Eduardo Habkost <address@hidden> writes:

> On Fri, Oct 30, 2015 at 05:23:27PM +0100, Markus Armbruster wrote:
>> Eduardo Habkost <address@hidden> writes:
>> 
>> > Changes v2 -> v3:
>> > * Removed patch: "vl.c: Convert error sentences to simpler phrases"
>> > * Removed patch: "vl.c: Reword -machine help error messages"
>> > * Removed patch: "vl.c: Reword fw_cfg name prefix warning"
>> > * Removed patch: "vl.c: Use US spelling for 'unrecognized'"
>> > * New patch: "vl.c: Change 'fail to parse' error message to 'failed to 
>> > parse'"
>> > * Squashed "vl.c: trivial: Don't wrap lines unnecessarily"
>> >   into "vl.c: Replace fprintf(stderr) with error_report()"
>> >
>> > Changes v1 -> v2:
>> > * Extra patches for many suggestions I got when changing vl.c to use
>> >   error_report()
>> >
>> > Eduardo Habkost (11):
>> >   vl.c: Replace fprintf(stderr) with error_report()
>> >   vl.c: Use error_report() when reporting shutdown signal
>> >   vl.c: Remove periods and exclamation points from error messages
>> >   vl.c: Use "warning:" prefix consistently on warnings
>> >   vl.c: Use "cannot" instead of "can not" in error messages
>> >   vl.c: Use 'quotes' instead of `quotes' in messages
>> >   vl.c: Remove unnecessary uppercase in error messages
>> >   vl.c: Change "fail to parse" error message to "failed to parse"
>> >   vl.c: Simplify "ignoring deprecated option" warnings
>> >   vl.c: Reword -no-kvm-pit-reinjection deprecation warning
>> >   vl.c: Use "%s support is disabled" error messages consistently
>> >
>> >  vl.c | 256 
>> > +++++++++++++++++++++++++++++++++----------------------------------
>> >  1 file changed, 125 insertions(+), 131 deletions(-)
>> 
>> I guess I would've squashed some of these together, and perhaps touched
>> up the rest of the files listed in MAINTAINERS under "Main loop", too
>> (cpus.c main-loop.c qemu-timer.c).  Regardless, this looks ready to go
>> through my tree.
>
> Thanks! Feel free to squash as many patches as you want together. I
> split the changes just to make them easier to review and discuss.

Please have a look at pull-error-2015-11-03 in my tree at
<http://repo.or.cz/qemu/armbru.git>.  Only squashing, no code change.
If you like the result, I'll post a pull request.