[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 07/17] qapi: Rework collision assertions
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v8 07/17] qapi: Rework collision assertions |
Date: |
Mon, 2 Nov 2015 14:24:00 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 11/02/2015 08:37 AM, Markus Armbruster wrote:
>
> Not checked: variant's members don't collide with non-variant members.
> I think this check got lost when we simplified
> QAPISchemaObjectTypeVariants to hold a single member.
Yep, I found the culprit: in your v2 proposal for QAPISchema, you had:
+class QAPISchemaObjectTypeVariant(QAPISchemaObjectTypeMember):
+ def __init__(self, name, typ, flat):
+ QAPISchemaObjectTypeMember.__init__(self, name, typ, False)
+ assert isinstance(flat, bool)
+ self.flat = flat
+ def check(self, schema, tag_type, seen):
+ QAPISchemaObjectTypeMember.check(self, schema, [], seen)
+ assert self.name in tag_type.values
+ if self.flat:
+ self.type.check(schema)
+ assert isinstance(self.type, QAPISchemaObjectType)
https://lists.gnu.org/archive/html/qemu-devel/2015-07/msg00394.html
but the 'if self.flat' clause was lost in v3:
https://lists.gnu.org/archive/html/qemu-devel/2015-08/msg00450.html
I am in fact reinstating it here, but for v9, will do it in a separate
patch rather than blended in with the rest of the changes.
[wow - we've been hammering at this since July?]
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v8 07/17] qapi: Rework collision assertions, Markus Armbruster, 2015/11/02
- Re: [Qemu-devel] [PATCH v8 07/17] qapi: Rework collision assertions, Eric Blake, 2015/11/02
- Re: [Qemu-devel] [PATCH v8 07/17] qapi: Rework collision assertions,
Eric Blake <=
- [Qemu-devel] [PATCH v8.5 0/4] rework of 7/17, Eric Blake, 2015/11/02
- [Qemu-devel] [PATCH v8.5 1/4] qapi: Drop all_members parameter from check(), Eric Blake, 2015/11/02
- Re: [Qemu-devel] [PATCH v8.5 1/4] qapi: Drop all_members parameter from check(), Markus Armbruster, 2015/11/03
- Re: [Qemu-devel] [PATCH v8.5 1/4] qapi: Drop all_members parameter from check(), Eric Blake, 2015/11/03
- Re: [Qemu-devel] [PATCH v8.5 1/4] qapi: Drop all_members parameter from check(), Markus Armbruster, 2015/11/03
- Re: [Qemu-devel] [PATCH v8.5 1/4] qapi: Drop all_members parameter from check(), Eric Blake, 2015/11/03
- Re: [Qemu-devel] [PATCH v8.5 1/4] qapi: Drop all_members parameter from check(), Markus Armbruster, 2015/11/03
- Re: [Qemu-devel] [PATCH v8.5 1/4] qapi: Drop all_members parameter from check(), Eric Blake, 2015/11/03