Re: [Qemu-devel] [PATCH v2 0/2] trace: fix Makefile dependencies

[Stefan Hajnoczi]

On Fri, Oct 30, 2015 at 09:53:13AM +0000, Stefan Hajnoczi wrote:
> v2:
>  * Use find(1) to catch all tracetool *.py files [Lluís]
> 
>    Note: I used find -name instead of find -path for better POSIX compliance
> 
> Issues with trace/Makefile.objs:
> 
> 1. Generated code is not recreated when patches modify scripts/tracetool/*.py.
>    Typically such patches also modify trace/*.[ch] and the result is build
>    failures when new C code compiles against stale generated code.
> 
> 2. The timestamp mechanism used to avoid unnecessary rebuilding is broken, it
>    currently requires two make invocations for a full build.
> 
> Stefan Hajnoczi (2):
>   trace: fix make foo-timestamp rules
>   trace: add make dependencies on tracetool source
> 
>  trace/Makefile.objs | 48 ++++++++++++++++++++++++++++--------------------
>  1 file changed, 28 insertions(+), 20 deletions(-)
> 
> -- 
> 2.4.3
> 
> 

Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing

Stefan

signature.asc
Description: PGP signature