[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 16/19] vnc: recycle empty vs->output buffer
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH 16/19] vnc: recycle empty vs->output buffer |
Date: |
Fri, 30 Oct 2015 21:27:55 +0900 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Fri, Oct 30, 2015 at 12:10:11PM +0100, Gerd Hoffmann wrote:
> From: Peter Lieven <address@hidden>
>
> If the vs->output buffer is empty it will be dropped
> by the next qio_buffer_move_empty in vnc_jobs_consume_buffer
> anyway. So reuse the allocated buffer from this buffer
> in the worker thread where we otherwise would start with
> an empty (unallocated buffer).
>
> Signed-off-by: Peter Lieven <address@hidden>
>
> [ added a comment describing the non-obvious optimization ]
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> ui/vnc-jobs.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
Reviewed-by: Daniel P. Berrange <address@hidden>
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
- Re: [Qemu-devel] [PATCH 18/19] buffer: factor out buffer_adj_size, (continued)
- [Qemu-devel] [PATCH 17/19] buffer: factor out buffer_req_size, Gerd Hoffmann, 2015/10/30
- [Qemu-devel] [PATCH 07/19] vnc: attach names to buffers, Gerd Hoffmann, 2015/10/30
- [Qemu-devel] [PATCH 02/19] buffer: add buffer_init, Gerd Hoffmann, 2015/10/30
- [Qemu-devel] [PATCH 14/19] vnc: only alloc server surface with clients connected, Gerd Hoffmann, 2015/10/30
- [Qemu-devel] [PATCH 16/19] vnc: recycle empty vs->output buffer, Gerd Hoffmann, 2015/10/30
- Re: [Qemu-devel] [PATCH 16/19] vnc: recycle empty vs->output buffer,
Daniel P. Berrange <=
- [Qemu-devel] [PATCH 12/19] vnc: factor out vnc_update_server_surface, Gerd Hoffmann, 2015/10/30
- [Qemu-devel] [PATCH 01/19] buffer: make the Buffer capacity increase in powers of two, Gerd Hoffmann, 2015/10/30
- [Qemu-devel] [PATCH 11/19] vnc: add vnc_width+vnc_height helpers, Gerd Hoffmann, 2015/10/30
- [Qemu-devel] [PATCH 15/19] vnc: fix local state init, Gerd Hoffmann, 2015/10/30
- [Qemu-devel] [PATCH 06/19] buffer: add tracing, Gerd Hoffmann, 2015/10/30