[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] configure: workaround for Clang 3.5.0
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] configure: workaround for Clang 3.5.0 |
Date: |
Thu, 29 Oct 2015 21:25:34 +0000 |
On 29 October 2015 at 21:20, Laszlo Ersek <address@hidden> wrote:
> On 10/29/15 21:29, John Snow wrote:
>> Here's a good takeaway quote:
>>
>> 'Also, _FORTIFY_SOURCE + glibc + clang is not supported and does not
>> work (for instance, it relies on __builtin_va_pack_len and friends,
>> which we have no intention of supporting), so glibc compatibility is
>> unlikely to be a strong motivator for a change here.'
>
> this quote would be compelling enough for me to disable _FORTIFY_SOURCE
> when clang is seen, no questions asked. The above is a public no-support
> statement from an apparently core clang developer, so "it happens to
> build without errors with version X.Y.Z." just don't cut it. A positive
> claim (bugzilla comment, release note, etc) would be necessary.
>
> ... As far as I'm concerned, of course. :)
I think I would agree with that.
thanks
-- PMM