[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/11] trace: split trace_init_file out of trace
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 03/11] trace: split trace_init_file out of trace_init_backends |
Date: |
Thu, 29 Oct 2015 17:23:18 +0000 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Mon, Oct 26, 2015 at 12:10:20PM +0300, Denis V. Lunev wrote:
> From: Paolo Bonzini <address@hidden>
>
> This is cleaner, and improves error reporting with -daemonize.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Denis V. Lunev <address@hidden>
> Reviewed-by: Christian Borntraeger <address@hidden>
> ---
> qemu-io.c | 2 +-
> trace/control.c | 17 ++++++++++++-----
> trace/control.h | 13 ++++++++++++-
> trace/simple.c | 6 ++----
> trace/simple.h | 4 ++--
> vl.c | 13 +++++++++----
> 6 files changed, 38 insertions(+), 17 deletions(-)
>
> diff --git a/qemu-io.c b/qemu-io.c
> index 269f17c..fbddf82 100644
> --- a/qemu-io.c
> +++ b/qemu-io.c
> @@ -440,7 +440,7 @@ int main(int argc, char **argv)
> }
> break;
> case 'T':
> - if (!trace_init_backends(optarg, NULL)) {
> + if (!trace_init_backends()) {
The previous patch dropped the 2nd argument to trace_init_backends(). I
guess that means the previous patch doesn't compile by itself?
Please move this hunk to the previous patch so that git-bisect(1) works
(i.e. each commit builds successfully and runs).
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH v2 00/11] simplify usage of tracepoints, and connect them to logging, Denis V. Lunev, 2015/10/26
- [Qemu-devel] [PATCH 02/11] trace: split trace_init_events out of trace_init_backends, Denis V. Lunev, 2015/10/26
- [Qemu-devel] [PATCH 05/11] trace: add "-trace enable=...", Denis V. Lunev, 2015/10/26
- [Qemu-devel] [PATCH 03/11] trace: split trace_init_file out of trace_init_backends, Denis V. Lunev, 2015/10/26
- Re: [Qemu-devel] [PATCH 03/11] trace: split trace_init_file out of trace_init_backends,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 04/11] trace: no need to call trace_backend_init in different branches now, Denis V. Lunev, 2015/10/26
- [Qemu-devel] [PATCH 01/11] trace: fix documentation, Denis V. Lunev, 2015/10/26
- [Qemu-devel] [PATCH 08/11] log: move qemu-log.c into util/ directory, Denis V. Lunev, 2015/10/26