[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] monitor: Plug memory leak on QMP error
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH] monitor: Plug memory leak on QMP error |
Date: |
Thu, 29 Oct 2015 11:41:38 -0400 |
On Thu, 29 Oct 2015 12:15:09 +0100
Markus Armbruster <address@hidden> wrote:
> Leak introduced in commit 8a4f501..710aec9, v2.4.0.
>
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Luiz Capitulino <address@hidden>
I think this can go through your tree?
> ---
> monitor.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/monitor.c b/monitor.c
> index 301a143..c59e85b 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -3862,6 +3862,7 @@ static void handle_qmp_command(JSONMessageParser
> *parser, QList *tokens)
> err_out:
> monitor_protocol_emitter(mon, data, local_err);
> qobject_decref(data);
> + error_free(local_err);
> QDECREF(input);
> QDECREF(args);
> }