Re: [Qemu-devel] [PATCH 3/9] block: Track discard requests

[Fam Zheng]

On Wed, 10/28 10:54, Kevin Wolf wrote:
> > -    return 0;
> > +out:
> > +    tracked_request_end(&req);
> > +    return ret;
> >  }
> 
> I would prefer an explicit ret = 0 before the out label because
> otherwise you're relying on the previous value that has been set
> somewhere in the loop. As far as I can tell, it's still correct, but it
> makes it needlessly hard to tell whether success is 0 or >= 0.

Good point, will fix.

Fam