Re: [Qemu-devel] [PATCH 6/6] virtio: drop virtqueue_map_sg

[Igor Mammedov]

On Tue, 27 Oct 2015 10:48:08 +0200
"Michael S. Tsirkin" <address@hidden> wrote:

> Deprecated in favor of virtqueue_map.
> 
> Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>

> ---
>  include/hw/virtio/virtio.h | 2 --
>  hw/virtio/virtio.c         | 7 -------
>  2 files changed, 9 deletions(-)
> 
> diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
> index 9d9abb4..205fadf 100644
> --- a/include/hw/virtio/virtio.h
> +++ b/include/hw/virtio/virtio.h
> @@ -151,8 +151,6 @@ void virtqueue_discard(VirtQueue *vq, const 
> VirtQueueElement *elem,
>  void virtqueue_fill(VirtQueue *vq, const VirtQueueElement *elem,
>                      unsigned int len, unsigned int idx);
>  
> -void virtqueue_map_sg(struct iovec *sg, hwaddr *addr,
> -    size_t num_sg, int is_write);
>  void virtqueue_map(VirtQueueElement *elem);
>  int virtqueue_pop(VirtQueue *vq, VirtQueueElement *elem);
>  int virtqueue_avail_bytes(VirtQueue *vq, unsigned int in_bytes,
> diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
> index 84e2320..be32145 100644
> --- a/hw/virtio/virtio.c
> +++ b/hw/virtio/virtio.c
> @@ -491,13 +491,6 @@ static void virtqueue_map_iovec(struct iovec *sg, hwaddr 
> *addr,
>      }
>  }
>  
> -/* Deprecated: don't use in new code */
> -void virtqueue_map_sg(struct iovec *sg, hwaddr *addr,
> -                      size_t num_sg, int is_write)
> -{
> -    virtqueue_map_iovec(sg, addr, &num_sg, num_sg, is_write);
> -}
> -
>  void virtqueue_map(VirtQueueElement *elem)
>  {
>      virtqueue_map_iovec(elem->in_sg, elem->in_addr, &elem->in_num,