[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 24/54] Add wrappers and handlers for sending/
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v8 24/54] Add wrappers and handlers for sending/receiving the postcopy-ram migration messages. |
Date: |
Mon, 26 Oct 2015 12:22:23 +0000 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
* Juan Quintela (address@hidden) wrote:
> "Dr. David Alan Gilbert (git)" <address@hidden> wrote:
> > From: "Dr. David Alan Gilbert" <address@hidden>
> >
> > The state of the postcopy process is managed via a series of messages;
> > * Add wrappers and handlers for sending/receiving these messages
> > * Add state variable that track the current state of postcopy
> >
> > Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> > Reviewed-by: Amit Shah <address@hidden>
>
> Reviewed-by: Juan Quintela <address@hidden>
>
>
> > + tmp[0] = cpu_to_be64(getpagesize());
> > + tmp[1] = cpu_to_be64(1ul << qemu_target_page_bits());
>
> we don't have a qemu_target_pagesize()?
>
> #fail
Well we didn't even have qemu_target_page_bits() until patch 1 - I
could add pagesize as well if you prefer?
> > + qemu_savevm_command_send(f, MIG_CMD_POSTCOPY_LISTEN, 0, NULL);
>
> Should we create a macro
>
> qemu_savevm_command_noargs_send(f, MIG_CMD_POSTCOPY_LISTEN);
>
> It is a "bit" clear, but saves a "whole" byte. Not convinced one way or
> other :-p
Doesn't seem worth it to me.
> > +
> > + case MIG_CMD_POSTCOPY_ADVISE:
> > + tmp64a = qemu_get_be64(f); /* hps */
> > + tmp64b = qemu_get_be64(f); /* tps */
> > + return loadvm_postcopy_handle_advise(mis, tmp64a, tmp64b);
>
> In the rest of the commands, you read the arguments inside the
> loadvm_postocpy_handle_*(), I think you should do the same here.
Hmm; actually most of them I don't do it in the handle_ function,
only the ones that were dynamically sized I do; however it is
neater doing it that way so I'll change all the places in that
switch to do it in the handle.
Dave
>
> Later, Juan.
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH v8 22/54] Rework loadvm path for subloops, (continued)
- [Qemu-devel] [PATCH v8 24/54] Add wrappers and handlers for sending/receiving the postcopy-ram migration messages., Dr. David Alan Gilbert (git), 2015/10/01
- [Qemu-devel] [PATCH v8 25/54] MIG_CMD_PACKAGED: Send a packaged chunk of migration stream, Dr. David Alan Gilbert (git), 2015/10/01
- [Qemu-devel] [PATCH v8 26/54] Modify save_live_pending for postcopy, Dr. David Alan Gilbert (git), 2015/10/01
- [Qemu-devel] [PATCH v8 27/54] postcopy: OS support test, Dr. David Alan Gilbert (git), 2015/10/01
- [Qemu-devel] [PATCH v8 28/54] migrate_start_postcopy: Command to trigger transition to postcopy, Dr. David Alan Gilbert (git), 2015/10/01