Re: [Qemu-devel] [PATCH] tests: re-enable vhost-user-test

[Marc-André Lureau]

HI

On Mon, Oct 26, 2015 at 12:38 PM, Michael S. Tsirkin <address@hidden> wrote:
> Like this then?
>
> if test target_name == "i386" -o target_name == "x86_64"
> then
>         echo "CONFIG_VHOST_NET_TEST_$target_name=y" >> $config_host_mak
> fi
>
>
> ifeq ($(CONFIG_VHOST_NET_i386),y)
> check-qtest-i386-y += tests/vhost-user-test$(EXESUF)
> endif
> ifeq ($(CONFIG_VHOST_NET_x86_64),y)
> check-qtest-x86_64-y += tests/vhost-user-test$(EXESUF)
> endif
>

I think I understand your idea, but it looks verbose, you are missing
the arm case, and I don't have a good way to test it.

>>
>> I don't feel very confortable with that sort of per-host/per-target
>> complex configure-time conditions. I would rather simply use a simple
>> runtime test check such as:
>
> Problem with runtime checks is it makes people not notice
> there's a problem.

fair enough


-- 
Marc-André Lureau