Re: [Qemu-devel] [PATCH] virtio: Notice when the system doesn't support MSIx at all

[Mark Cave-Ayland]

On 26/10/15 10:03, Michael S. Tsirkin wrote:

> On Mon, Oct 26, 2015 at 09:44:47AM +0000, Mark Cave-Ayland wrote:
>> On 27/09/15 15:40, Peter Maydell wrote:
>>
>>> Ping^2 -- this is still confusing users, cf bug LP:1500175.
>>>
>>> thanks
>>> -- PMM
>>>
>>> On 6 July 2015 at 11:38, Peter Maydell <address@hidden> wrote:
>>>> On 3 July 2015 at 09:22, Mark Cave-Ayland <address@hidden> wrote:
>>>>> On 19/05/15 21:29, Richard Henderson wrote:
>>>>>
>>>>>> And do not issue an error_report in that case.
>>>>>>
>>>>>> Signed-off-by: Richard Henderson <address@hidden>
>>>>>> ---
>>>>>>  hw/virtio/virtio-pci.c | 15 ++++++++++-----
>>>>>>  1 file changed, 10 insertions(+), 5 deletions(-)
>>>>>> --
>>>>>>
>>>>>> This seems to be about the only sane way to test the value of
>>>>>> msi_supported from here.  Thoughts?
>>>>
>>>>> Ping? Any chance of getting this applied for 2.4 since it's something
>>>>> that I do get emails about for SPARC64?
>>>>
>>>> Michael would like a respin with the commit message correction
>>>> he suggested. RTH -- could you send out a fixed up version, please?
> 
> I don't think there was a reply to this, and by now the patch doesn't apply.

Hmmm that's a shame. I'm not overly familiar with the PCI parts of QEMU,
so is it much work to rebase?

>>>>
>>>> thanks
>>>> -- PMM
>>
>> Another ping on this patch - please can we have it for 2.5? It has been
>> around since before 2.4 and I'd hate for it to miss another release :(
>>
>>
>> ATB,
>>
>> Mark.
> 
> Pls address the issues if you want this applied.

The patch came from Richard rather than myself - my only involvement has
been to champion the patch since both myself and Peter have had reports
of this message confusing users.


ATB,

Mark.