[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 03/14] qapi: Provide nicer array names in int
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v7 03/14] qapi: Provide nicer array names in introspection |
Date: |
Thu, 22 Oct 2015 18:12:44 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Eric Blake <address@hidden> writes:
> For the sake of humans reading introspection output, it is nice
> to have the name of implicit array types be recognizable as
> arrays of the underlying type. However, while this patch allows
> humans to skip from a command with return type "[123]" straight
> to the definition of type "123" without having to first inspect
> type "[123]", document that this shortcut should not be taken by
> client apps.
Personally, I still don't see much value in special-casing array names.
On the other hand, the patch is really simple.
> This makes the resulting introspection string slightly larger by
> default, but slightly smaller when -u is in use (as '[FOO]' is
> nicer than 'FOOList' for expressing 'array of FOO').
Size with -u is unimportant.
If we don't want to pay the prize in size without -u, we can make it
conditional on -u. But with -u, [FOO] isn't much of an improvement over
FooList.
Anyway, if you want the feature, I'll take the patch.
- [Qemu-devel] [PATCH v7 00/14] alternate layout (post-introspection cleanups, subset C), Eric Blake, 2015/10/17
- [Qemu-devel] [PATCH v7 04/14] qapi-introspect: Guarantee particular sorting, Eric Blake, 2015/10/17
- [Qemu-devel] [PATCH v7 01/14] qapi: Use generated TestStruct machinery in tests, Eric Blake, 2015/10/17
- [Qemu-devel] [PATCH v7 03/14] qapi: Provide nicer array names in introspection, Eric Blake, 2015/10/17
- Re: [Qemu-devel] [PATCH v7 03/14] qapi: Provide nicer array names in introspection,
Markus Armbruster <=
- [Qemu-devel] [PATCH v7 06/14] qapi: Update tests related to QMP/branch collisions, Eric Blake, 2015/10/17
- [Qemu-devel] [PATCH v7 08/14] qapi: Fix alternates that accept 'number' but not 'int', Eric Blake, 2015/10/17
- [Qemu-devel] [PATCH v7 09/14] qapi: Remove dead visitor code, Eric Blake, 2015/10/17
- [Qemu-devel] [PATCH v7 14/14] qapi: Simplify visits of optional fields, Eric Blake, 2015/10/17
- [Qemu-devel] [PATCH v7 05/14] qapi: Rework collision assertions, Eric Blake, 2015/10/17
- [Qemu-devel] [PATCH v7 12/14] qapi: Test failure in middle of array parse, Eric Blake, 2015/10/17
- [Qemu-devel] [PATCH v7 10/14] qapi: Plug leaks in test-qmp-*, Eric Blake, 2015/10/17
- [Qemu-devel] [PATCH v7 13/14] qapi: More tests of input arrays, Eric Blake, 2015/10/17
- [Qemu-devel] [PATCH v7 02/14] qapi: Strengthen test of TestStructList, Eric Blake, 2015/10/17