qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC V5 6/9] hw/intc: arm_gicv3_spi_its


From: Shlomo Pongratz
Subject: Re: [Qemu-devel] [PATCH RFC V5 6/9] hw/intc: arm_gicv3_spi_its
Date: Wed, 21 Oct 2015 16:14:52 +0300



On Wednesday, October 21, 2015, Pavel Fedin <address@hidden> wrote:
 Hello!

> I just added a placeholder, I didn't add any functionality.

 I see. Just wanted to say, that if we accept my proposal (implementing ITS as a separate object), then the only thing we would do with this placeholder is to remove it. It should go then to something like hw/intc/arm_gicv3_its.c and its object should inherit from TYPE_ARM_GICV3_ITS_COMMON.
 Or do you have some explicit reasons to have everything as a monolith?

No I just didn't want to have 3 stub files spi, its and its_control.
Do you suggest that I'll split it to 3 files?

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia



reply via email to

[Prev in Thread] Current Thread [Next in Thread]