[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 09/12] block: Add "drained begin/end" for interna
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PATCH v5 09/12] block: Add "drained begin/end" for internal snapshot |
Date: |
Wed, 21 Oct 2015 10:06:46 +0800 |
This ensures the atomicity of the transaction by avoiding processing of
external requests such as those from ioeventfd.
state->bs is assigned right after bdrv_drained_begin. Because it was
used as the flag for deletion or not in abort, now we need a separate
flag - InternalSnapshotState.created.
Signed-off-by: Fam Zheng <address@hidden>
---
blockdev.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 52f44b2..92c2d0d 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1370,6 +1370,7 @@ typedef struct InternalSnapshotState {
BlockDriverState *bs;
AioContext *aio_context;
QEMUSnapshotInfo sn;
+ bool created;
} InternalSnapshotState;
static void internal_snapshot_prepare(BlkTransactionState *common,
@@ -1407,6 +1408,8 @@ static void internal_snapshot_prepare(BlkTransactionState
*common,
/* AioContext is released in .clean() */
state->aio_context = blk_get_aio_context(blk);
aio_context_acquire(state->aio_context);
+ state->bs = blk_bs(blk);
+ bdrv_drained_begin(state->bs);
if (!blk_is_available(blk)) {
error_setg(errp, QERR_DEVICE_HAS_NO_MEDIUM, device);
@@ -1465,7 +1468,7 @@ static void internal_snapshot_prepare(BlkTransactionState
*common,
}
/* 4. succeed, mark a snapshot is created */
- state->bs = bs;
+ state->created = true;
}
static void internal_snapshot_abort(BlkTransactionState *common)
@@ -1476,7 +1479,7 @@ static void internal_snapshot_abort(BlkTransactionState
*common)
QEMUSnapshotInfo *sn = &state->sn;
Error *local_error = NULL;
- if (!bs) {
+ if (!state->created) {
return;
}
@@ -1497,6 +1500,7 @@ static void internal_snapshot_clean(BlkTransactionState
*common)
common, common);
if (state->aio_context) {
+ bdrv_drained_end(state->bs);
aio_context_release(state->aio_context);
}
}
--
2.4.3
- Re: [Qemu-devel] [Qemu-block] [PATCH v5 04/12] aio: introduce aio_{disable, enable}_external, (continued)
[Qemu-devel] [PATCH v5 05/12] block: Introduce "drained begin/end" API, Fam Zheng, 2015/10/20
[Qemu-devel] [PATCH v5 06/12] block: Add "drained begin/end" for transactional external snapshot, Fam Zheng, 2015/10/20
[Qemu-devel] [PATCH v5 07/12] block: Add "drained begin/end" for transactional backup, Fam Zheng, 2015/10/20
[Qemu-devel] [PATCH v5 08/12] block: Add "drained begin/end" for transactional blockdev-backup, Fam Zheng, 2015/10/20
[Qemu-devel] [PATCH v5 09/12] block: Add "drained begin/end" for internal snapshot,
Fam Zheng <=
[Qemu-devel] [PATCH v5 10/12] block: Introduce BlockDriver.bdrv_drain callback, Fam Zheng, 2015/10/20
[Qemu-devel] [PATCH v5 11/12] qed: Implement .bdrv_drain, Fam Zheng, 2015/10/20
[Qemu-devel] [PATCH v5 12/12] tests: Add test case for aio_disable_external, Fam Zheng, 2015/10/20
Re: [Qemu-devel] [PATCH v5 00/12] block: Protect nested event loop with bdrv_drained_begin and bdrv_drained_end, Kevin Wolf, 2015/10/21