[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 03/16] sockets: allow port to be NULL when li
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 03/16] sockets: allow port to be NULL when listening on IP address |
Date: |
Mon, 19 Oct 2015 16:12:00 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 10/12/2015 05:14 AM, Daniel P. Berrange wrote:
> If the port in the SocketAddress struct is NULL, it can allow
> the kernel to automatically select a free port. This is useful
> in particular in unit tests to avoid a race trying to find a
> free port to run a test case on.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> util/qemu-sockets.c | 18 +++++++++++++-----
> 1 file changed, 13 insertions(+), 5 deletions(-)
>
Right now, the qapi documents InetSocketAddress.port as mandatory.
Should we relax it to be optional, rather than special-casing the empty
string "" to mean no port?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 00/16] Introduce I/O channels framework, Daniel P. Berrange, 2015/10/15
- [Qemu-devel] [PATCH v2 03/16] sockets: allow port to be NULL when listening on IP address, Daniel P. Berrange, 2015/10/12
- Re: [Qemu-devel] [PATCH v2 03/16] sockets: allow port to be NULL when listening on IP address,
Eric Blake <=
- Re: [Qemu-devel] [PATCH v2 03/16] sockets: allow port to be NULL when listening on IP address, Knut Omang, 2015/10/22
- Re: [Qemu-devel] [PATCH v2 03/16] sockets: allow port to be NULL when listening on IP address, Daniel P. Berrange, 2015/10/22
- Re: [Qemu-devel] [PATCH v2 03/16] sockets: allow port to be NULL when listening on IP address, Peter Maydell, 2015/10/22
- Re: [Qemu-devel] [PATCH v2 03/16] sockets: allow port to be NULL when listening on IP address, Markus Armbruster, 2015/10/22
- Re: [Qemu-devel] [PATCH v2 03/16] sockets: allow port to be NULL when listening on IP address, Daniel P. Berrange, 2015/10/22
- Re: [Qemu-devel] [PATCH v2 03/16] sockets: allow port to be NULL when listening on IP address, Eric Blake, 2015/10/22
- Re: [Qemu-devel] [PATCH v2 03/16] sockets: allow port to be NULL when listening on IP address, Shannon Zhao, 2015/10/31
- Re: [Qemu-devel] [PATCH v2 03/16] sockets: allow port to be NULL when listening on IP address, Peter Maydell, 2015/10/31
[Qemu-devel] [PATCH v2 04/16] ui: convert VNC startup code to use SocketAddress, Daniel P. Berrange, 2015/10/12