Re: [Qemu-devel] [PATCH v2 6/9] target-i386: Handle I/O breakpoints

[Richard Henderson]

On 10/19/2015 07:30 AM, Eduardo Habkost wrote:
> > >+        /* Notice when we should enable calls to bpt_io.  */
> > >+        return (hw_breakpoint_enabled(env->dr[7], index)
> > >+                ? HF_IOBPT_MASK : 0);
> checkpatch.pl error:
>
>    ERROR: return is not a function, parentheses are not required
>    #57: FILE: target-i386/bpt_helper.c:69:
>    +        return (hw_breakpoint_enabled(env->dr[7], index)
>
>    total: 1 errors, 0 warnings, 242 lines checked
>
> I will fix it in v3.

In this case checkpatch is wrong, imo.  The parenthesis are not there to "make 
return a function", but to make the multi-line expression indent properly.


r~