Re: [Qemu-devel] [PATCH v9 02/17] qapi: Reserve '*List' type names for arrays

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> We already reserved '*Kind' for implicit enums (since commit

"We reserved '*Kind' since" sounds odd.  Present tense?

> 4dc2e69), but failed to reserve '*List' for array types.  Since
> no QMP was yet using it, we might as well make the reservation
> official.

Uhm, how can we fail to reserve something, and then make the reservation
official?  I think what you're trying to say is something like

    Type names ending in 'List' can clash with array types in generated
    C.  We don't currently use such names.  Outlaw them.

    Precedence: commit 4dc2e69 outlawed names ending in 'Kind', because
    they can clash with implicit enum types of unions.

> Note that this forbids creation of new types or commands ending
> in 'List', but does NOT forbid abuse of attempts like ['intList']
> for creating a 2-dimensional array of 'int'.

Really?  If I write ['T'], then T must be a declared type, mustn't it?
And after this patch, I cant declare type intList, can I?

>                                               The whole idea of
> multi-dimensional arrays needs more design thought, best left for
> another day.
>
> Signed-off-by: Eric Blake <address@hidden>

Patch looks good to me.