Re: [Qemu-devel] [PATCH v2] arm_gic_kvm: Disable live migration if not supported

[Pavel Fedin]

 Hello!

> > +    if (kvm_arm_gic_can_save_restore(s)) {
> > +        kvm_arm_gic_put(s);
> > +    }
> 
> Why change the reset method in a patch that's dealing with adding
> a warning about migration?

 Since pre_save and post_load will never be called if migration is disabled, i 
removed unnecessary checks from there. But, since reset method calls post_load, 
i had to add the check there.
 Actually, i would factor away kvm_arm_gic_reset() completely, because all it 
does is calling parent's reset, then calling post_load. This can perfectly be 
done in parent class. For software-emulated GICv3 post_load callback is simply 
not used, so that would be safe.
 But, i remember that you don't like just refactoring, so i decided to stop at 
the point which you see. :)
 
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia