[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 3/3] virtio-blk: switch off scsi-passthrough by d
From: |
Cornelia Huck |
Subject: |
[Qemu-devel] [PATCH v2 3/3] virtio-blk: switch off scsi-passthrough by default |
Date: |
Fri, 16 Oct 2015 12:25:54 +0200 |
Devices that are compliant with virtio-1 do not support scsi
passthrough any more (and it has not been a recommended setup
anyway for quite some time). To avoid having to switch it off
explicitly in newer qemus that turn on virtio-1 by default, let's
switch the default to scsi=false for 2.5.
Signed-off-by: Cornelia Huck <address@hidden>
---
hw/block/virtio-blk.c | 2 +-
include/hw/compat.h | 6 +++++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 8beb26b..999dbd7 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -975,7 +975,7 @@ static Property virtio_blk_properties[] = {
DEFINE_PROP_STRING("serial", VirtIOBlock, conf.serial),
DEFINE_PROP_BIT("config-wce", VirtIOBlock, conf.config_wce, 0, true),
#ifdef __linux__
- DEFINE_PROP_BIT("scsi", VirtIOBlock, conf.scsi, 0, true),
+ DEFINE_PROP_BIT("scsi", VirtIOBlock, conf.scsi, 0, false),
#endif
DEFINE_PROP_BIT("request-merging", VirtIOBlock, conf.request_merging, 0,
true),
diff --git a/include/hw/compat.h b/include/hw/compat.h
index 095de5d..93e71af 100644
--- a/include/hw/compat.h
+++ b/include/hw/compat.h
@@ -2,7 +2,11 @@
#define HW_COMPAT_H
#define HW_COMPAT_2_4 \
- /* empty */
+ {\
+ .driver = "virtio-blk-device",\
+ .property = "scsi",\
+ .value = "true",\
+ },
#define HW_COMPAT_2_3 \
{\
--
2.3.9
- [Qemu-devel] [PATCH v2 0/3] virtio-blk: no scsi-passthrough by default, Cornelia Huck, 2015/10/16
- [Qemu-devel] [PATCH v2 2/3] ppc/spapr: add 2.4 compat props, Cornelia Huck, 2015/10/16
- [Qemu-devel] [PATCH v2 3/3] virtio-blk: switch off scsi-passthrough by default,
Cornelia Huck <=
- Re: [Qemu-devel] [PATCH v2 3/3] virtio-blk: switch off scsi-passthrough by default, Christian Borntraeger, 2015/10/16
- Re: [Qemu-devel] [PATCH v2 3/3] virtio-blk: switch off scsi-passthrough by default, Cornelia Huck, 2015/10/16
- Re: [Qemu-devel] [PATCH v2 3/3] virtio-blk: switch off scsi-passthrough by default, Christian Borntraeger, 2015/10/16
- Re: [Qemu-devel] [PATCH v2 3/3] virtio-blk: switch off scsi-passthrough by default, Michael S. Tsirkin, 2015/10/18
- Re: [Qemu-devel] [PATCH v2 3/3] virtio-blk: switch off scsi-passthrough by default, Cornelia Huck, 2015/10/19
- Re: [Qemu-devel] [PATCH v2 3/3] virtio-blk: switch off scsi-passthrough by default, Michael S. Tsirkin, 2015/10/19
- Re: [Qemu-devel] [PATCH v2 3/3] virtio-blk: switch off scsi-passthrough by default, Cornelia Huck, 2015/10/19
[Qemu-devel] [PATCH v2 1/3] s390x: include HW_COMPAT_* props, Cornelia Huck, 2015/10/16
Re: [Qemu-devel] [PATCH v2 0/3] virtio-blk: no scsi-passthrough by default, Paolo Bonzini, 2015/10/16