[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 9/9] kvm/x86: Hyper-V kvm exit
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 9/9] kvm/x86: Hyper-V kvm exit |
|
Date: |
Fri, 16 Oct 2015 09:51:58 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 16/10/2015 09:07, Denis V. Lunev wrote:
>
> + /* KVM_EXIT_HYPERV */
> + struct kvm_hyperv_exit hyperv;
> +Indicates that the VCPU exits into userspace to process some tasks
> +related with Hyper-V emulation. Currently used to synchronize modified
> +Hyper-V SynIC state with userspace.
> +
The documentation should include the definition of the struct and the
definition of the subtypes (currently KVM_EXIT_HYPERV_SYNIC only).
Documentation for KVM_CAP_HYPERV_SINIC and KVM_IRQ_ROUTING_HV_SINT is
missing, too.
Finally, it would be better to have unit tests in kvm-unit-tests.
Either this or QEMU support is a requirement for merging, and the unit
tests are probably easier.
But apart from this, the series looks great and I'm already applying it
to kvm/queue so that it gets some more testing.
Paolo
- [Qemu-devel] [PATCH v2 0/9] Hyper-V synthetic interrupt controller, Denis V. Lunev, 2015/10/16
- [Qemu-devel] [PATCH 2/9] kvm/eventfd: factor out kvm_notify_acked_gsi(), Denis V. Lunev, 2015/10/16
- [Qemu-devel] [PATCH 1/9] kvm/eventfd: avoid loop inside irqfd_update(), Denis V. Lunev, 2015/10/16
- [Qemu-devel] [PATCH 4/9] kvm/irqchip: allow only multiple irqchip routes per GSI, Denis V. Lunev, 2015/10/16
- [Qemu-devel] [PATCH 5/9] kvm/irqchip: kvm_arch_irq_routing_update renaming split, Denis V. Lunev, 2015/10/16
- [Qemu-devel] [PATCH 3/9] kvm/eventfd: add arch-specific set_irq, Denis V. Lunev, 2015/10/16
- [Qemu-devel] [PATCH 6/9] drivers/hv: share Hyper-V SynIC constants with userspace, Denis V. Lunev, 2015/10/16
- [Qemu-devel] [PATCH 7/9] kvm/x86: split ioapic-handled and EOI exit bitmaps, Denis V. Lunev, 2015/10/16
- [Qemu-devel] [PATCH 9/9] kvm/x86: Hyper-V kvm exit, Denis V. Lunev, 2015/10/16
- [Qemu-devel] [PATCH 8/9] kvm/x86: Hyper-V synthetic interrupt controller, Denis V. Lunev, 2015/10/16