[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 04/22] util: Infrastructure for computing rec
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2 04/22] util: Infrastructure for computing recent averages |
Date: |
Tue, 13 Oct 2015 16:32:56 +0100 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Fri, Oct 02, 2015 at 05:26:14PM +0300, Alberto Garcia wrote:
> +int64_t cpu_get_clock(void)
> +{
> + return my_clock_value;
> +}
Please add a comment here explaining that this is the clock for
QEMU_CLOCK_VIRTUAL.
> +/* Account a value
> + *
> + * @ta: the TimedAverage structure
> + * @value: the value to account
> + */
> +void timed_average_account(TimedAverage *ta, uint64_t value)
> +{
> + int i;
> + check_expirations(ta);
> +
> + /* Do the accouting in both windows at the same time */
s/accouting/accounting/
- [Qemu-devel] [PATCH v2 00/22] Extended I/O accounting, Alberto Garcia, 2015/10/08
- [Qemu-devel] [PATCH v2 16/22] virtio-blk: Account for failed and invalid operations, Alberto Garcia, 2015/10/08
- [Qemu-devel] [PATCH v2 01/22] xen_disk: Account for flush operations, Alberto Garcia, 2015/10/08
- [Qemu-devel] [PATCH v2 04/22] util: Infrastructure for computing recent averages, Alberto Garcia, 2015/10/08
- Re: [Qemu-devel] [PATCH v2 04/22] util: Infrastructure for computing recent averages,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v2 22/22] block: Update copyright of the accounting code, Alberto Garcia, 2015/10/08
- [Qemu-devel] [PATCH v2 05/22] block: Add idle_time_ns to BlockDeviceStats, Alberto Garcia, 2015/10/08
- [Qemu-devel] [PATCH v2 06/22] block: Add "supports_stats" field to BlockStats, Alberto Garcia, 2015/10/08
[Qemu-devel] [PATCH v2 07/22] block: Add statistics for failed and invalid I/O operations, Alberto Garcia, 2015/10/08