[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 46/50] ivshmem: remove EventfdEntry.vector
From: |
marcandre . lureau |
Subject: |
[Qemu-devel] [PULL v2 46/50] ivshmem: remove EventfdEntry.vector |
Date: |
Mon, 12 Oct 2015 18:41:40 +0200 |
From: Marc-André Lureau <address@hidden>
No need to store an extra int for the vector number when it can be
computed easily by looking at the position in the array.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Claudio Fontana <address@hidden>
---
hw/misc/ivshmem.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 2fdb92b..3283874 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -68,7 +68,6 @@ typedef struct Peer {
typedef struct EventfdEntry {
PCIDevice *pdev;
- int vector;
} EventfdEntry;
typedef struct IVShmemState {
@@ -287,9 +286,11 @@ static void fake_irqfd(void *opaque, const uint8_t *buf,
int size) {
EventfdEntry *entry = opaque;
PCIDevice *pdev = entry->pdev;
+ IVShmemState *s = IVSHMEM(pdev);
+ int vector = entry - s->eventfd_table;
- IVSHMEM_DPRINTF("interrupt on vector %p %d\n", pdev, entry->vector);
- msix_notify(pdev, entry->vector);
+ IVSHMEM_DPRINTF("interrupt on vector %p %d\n", pdev, vector);
+ msix_notify(pdev, vector);
}
static CharDriverState* create_eventfd_chr_device(void * opaque, EventNotifier
*n,
@@ -311,7 +312,6 @@ static CharDriverState* create_eventfd_chr_device(void *
opaque, EventNotifier *
/* if MSI is supported we need multiple interrupts */
if (ivshmem_has_feature(s, IVSHMEM_MSI)) {
s->eventfd_table[vector].pdev = PCI_DEVICE(s);
- s->eventfd_table[vector].vector = vector;
qemu_chr_add_handlers(chr, ivshmem_can_receive, fake_irqfd,
ivshmem_event, &s->eventfd_table[vector]);
--
2.4.3
- Re: [Qemu-devel] [PULL v2 01/50] tests: Add ivshmem qtest, (continued)
- [Qemu-devel] [PULL v2 15/50] ivshmem: remove useless ivshmem_update_irq() val argument, marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v2 07/50] ivshmem: remove unnecessary dup(), marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v2 24/50] ivshmem: migrate with VMStateDescription, marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v2 25/50] ivshmem: shmfd can be 0, marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v2 19/50] ivshmem: improve error handling, marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v2 27/50] ivshmem: add device description, marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v2 30/50] ivshmem: error on too many eventfd received, marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v2 35/50] ivshmem-server: fix hugetlbfs support, marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v2 36/50] docs: update ivshmem device spec, marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v2 46/50] ivshmem: remove EventfdEntry.vector,
marcandre . lureau <=
- [Qemu-devel] [PULL v2 45/50] ivshmem: add hostmem backend, marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v2 43/50] ivshmem: do not keep shm_fd open, marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v2 28/50] ivshmem: fix pci_ivshmem_exit(), marcandre . lureau, 2015/10/15