[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv18/8] trace: [tcg] Add per-vCPU tracing states f
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCHv18/8] trace: [tcg] Add per-vCPU tracing states for events with the 'vcpu' property |
Date: |
Tue, 13 Oct 2015 11:50:30 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 10/13/2015 11:11 AM, Lluís Vilanova wrote:
> Signed-off-by: Lluís Vilanova <address@hidden>
> ---
Interface review only.
> +++ b/qapi/trace.json
> @@ -64,3 +64,34 @@
> ##
> { 'command': 'trace-event-set-state',
> 'data': {'name': 'str', 'enable': 'bool', '*ignore-unavailable': 'bool'} }
> +
> +##
> +# @trace-event-get-cpu-state:
> +#
> +# Query the state of events in a given vCPU.
> +#
> +# @name: Event name pattern.
> +# @vcpu: The vCPU to check.
> +#
> +# Returns: @TraceEventInfo of the matched events
> +#
> +# Since 2.2
2.5, not 2.2
> +##
> +{ 'command': 'trace-event-get-cpu-state',
> + 'data': {'name': 'str', 'vcpu': 'int'},
> + 'returns': ['TraceEventInfo'] }
> +
> +##
> +# @trace-event-set-cpu-state:
> +#
> +# Set the dynamic state of events in a given vCPU.
> +#
> +# @name: Event name pattern.
> +# @vcpu: The vCPU to act upon.
> +# @enable: Whether to enable tracing.
> +# @ignore-unavailable: #optional Do not match unavailable events with @name.
> +#
> +# Since 2.2
2.5, not 2.2
> +##
> +{ 'command': 'trace-event-set-cpu-state',
> + 'data': {'name': 'str', 'vcpu': 'int', 'enable': 'bool',
> '*ignore-unavailable': 'bool'} }
This looks identical to trace-event-set-state, except that it now has a
'vcpu':'int' argument. Would it be any simpler to just modify the
existing command:
##
# @trace-event-set-state:
...
# @vcpu: #optional If provided, limit the state change to the given vcpu
(default act on all vcpus) (since 2.5)
#
# Since 2.2
##
{ 'command': 'trace-event-set-state',
'data': {'name': 'str', 'enable': 'bool',
'*vcpu': 'int', '*ignore-unavailable': 'bool'} }
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCHv13/8] trace: [tcg] Identify events with the 'vcpu' property, (continued)
- [Qemu-devel] [PATCHv15/8] exec: [ŧcg] Use multiple physical TB caches, Lluís Vilanova, 2015/10/13
- [Qemu-devel] [PATCHv14/8] exec: [tcg] Refactor flush of per-CPU virtual TB cache, Lluís Vilanova, 2015/10/13
- [Qemu-devel] [PATCHv12/8] trace: Add 'vcpu' event property, Lluís Vilanova, 2015/10/13
- [Qemu-devel] [PATCHv18/8] trace: [tcg] Add per-vCPU tracing states for events with the 'vcpu' property, Lluís Vilanova, 2015/10/13
- [Qemu-devel] [PATCHv17/8] [trivial] Track when QEMU has finished initialization, Lluís Vilanova, 2015/10/13
- [Qemu-devel] [PATCHv16/8] exec: [tcg] Track which vCPU is performing translation and execution, Lluís Vilanova, 2015/10/13
- [Qemu-devel] [PATCHv11/8] trace: Add support for vCPU pointers in trace events, Lluís Vilanova, 2015/10/13