Re: [Qemu-devel] [PATCH] config: enable ivshmem on POSIX

[Peter Maydell]

On 12 October 2015 at 17:05, Marc-André Lureau <address@hidden> wrote:
> Hi Peter
>
> ----- Original Message -----
>> On 12 October 2015 at 16:12,  <address@hidden> wrote:
>> > From: Marc-André Lureau <address@hidden>
>> >
>> > ivshmem doesn't actually require kvm, so enable it when POSIX is
>> > enabled. (it is required however when ioeventfd is enabled)
>> >
>> > Signed-off-by: Marc-André Lureau <address@hidden>
>> > ---
>> >  default-configs/pci.mak | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/default-configs/pci.mak b/default-configs/pci.mak
>> > index 7e10903..f250119 100644
>> > --- a/default-configs/pci.mak
>> > +++ b/default-configs/pci.mak
>> > @@ -35,5 +35,5 @@ CONFIG_SDHCI=y
>> >  CONFIG_EDU=y
>> >  CONFIG_VGA=y
>> >  CONFIG_VGA_PCI=y
>> > -CONFIG_IVSHMEM=$(CONFIG_KVM)
>> > +CONFIG_IVSHMEM=$(CONFIG_POSIX)
>> >  CONFIG_ROCKER=y
>>
>> I did a quick test of an OSX build with this change and
>> you'll be pleased to know it builds ok, no new compile
>> warnings :-)
>
> Yes indeed, thanks for checking!
>
> Can I add tested-by or do you add your signed off?

I didn't provide a tested-by tag because I didn't actually
check the functionality, just that it built.

-- PMM