Re: [Qemu-devel] [PULL 41/48] tests: add ivshmem qtest

[Marc-André Lureau]

Hi Michael

On Sat, Oct 10, 2015 at 11:29 PM, Michael Roth
<address@hidden> wrote:
> Noticed this while processing tests/test-qga.c series: g_mkdtemp*() are
> glib 2.30 and newer so we need something for 2.22 compat. Since it's a
> linux-only test, mkdtemp()+chmod() should probably cut it. For qga
> series one I'll fix it up in my tree.

Thanks, I fixed it too.

> I tried to scan for other instances in this series, it looks like you
> might have issue with g_thread_try_new() (glib 2.32, but we have compat
> definitions for g_thread_new() at least).
> Others glib functions look okay, from what I can tell.

There was actually a version check, but it turns out it isn't really
needed, so I dropped it

cheers

-- 
Marc-André Lureau