qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Exit on reset for armv7-m


From: Michael Davidsaver
Subject: Re: [Qemu-devel] [PATCH] Exit on reset for armv7-m
Date: Thu, 08 Oct 2015 21:24:16 -0400
User-agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Icedove/31.8.0

On 10/08/2015 04:09 PM, Peter Crosthwaite wrote:
> On Thu, Oct 8, 2015 at 8:40 AM, Michael Davidsaver
> <address@hidden> wrote:
>> Implement the SYSRESETREQ bit of the AIRCR register
>> for armv7-m (ie. cortex-m3).
>>
> 
> This would serve better as the commit message to the patch (which I
> notice is missing a commit blurb).

Does this warrant sending an updated patch?  I would have no objection to 
whomever applies the patch simply changing the commit message.

>> A small patch to see if I have the submission process figured out.
>>
> 
> It is usual for the cover and patches to be enumerated together with
> the cover being patch 0, e.g. the subject would read [PATCH 0/1]. the
> --cover-letter switch of git format-patch does this for you.

Alas in this case it did not.  Probably because I omitted '--numbered'.

>> Michael Davidsaver (1):
> 
> When sending a single, a cover is not required. You could just send
> the patch on it's own. This will all be useful when you come to send
> multi-patch series however.

Noted.

Thanks for the feedback Peter.


Michael



reply via email to

[Prev in Thread] Current Thread [Next in Thread]