[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 14/25] net: add trace_vhost_user_event
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 14/25] net: add trace_vhost_user_event |
Date: |
Fri, 9 Oct 2015 00:17:32 +0300 |
From: Marc-André Lureau <address@hidden>
Replace error_report() and use tracing instead. It's not an error to get
a connection or a disconnection, so silence this and trace it instead.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
net/vhost-user.c | 4 ++--
trace-events | 3 +++
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/net/vhost-user.c b/net/vhost-user.c
index 8f354eb..9b38431 100644
--- a/net/vhost-user.c
+++ b/net/vhost-user.c
@@ -15,6 +15,7 @@
#include "qemu/config-file.h"
#include "qemu/error-report.h"
#include "qmp-commands.h"
+#include "trace.h"
typedef struct VhostUserState {
NetClientState nc;
@@ -148,18 +149,17 @@ static void net_vhost_user_event(void *opaque, int event)
NET_CLIENT_OPTIONS_KIND_NIC,
MAX_QUEUE_NUM);
s = DO_UPCAST(VhostUserState, nc, ncs[0]);
+ trace_vhost_user_event(s->chr->label, event);
switch (event) {
case CHR_EVENT_OPENED:
if (vhost_user_start(queues, ncs) < 0) {
exit(1);
}
qmp_set_link(name, true, &err);
- error_report("chardev \"%s\" went up", s->chr->label);
break;
case CHR_EVENT_CLOSED:
qmp_set_link(name, true, &err);
vhost_user_stop(queues, ncs);
- error_report("chardev \"%s\" went down", s->chr->label);
break;
}
diff --git a/trace-events b/trace-events
index 6790292..678f6f0 100644
--- a/trace-events
+++ b/trace-events
@@ -1699,3 +1699,6 @@ qcrypto_tls_creds_x509_load_cert_list(void *creds, const
char *file) "TLS creds
# crypto/tlssession.c
qcrypto_tls_session_new(void *session, void *creds, const char *hostname,
const char *aclname, int endpoint) "TLS session new session=%p creds=%p
hostname=%s aclname=%s endpoint=%d"
+
+# net/vhost-user.c
+vhost_user_event(const char *chr, int event) "chr: %s got event: %d"
--
MST
- [Qemu-devel] [PULL 00/25] virtio,pc features, fixes, Michael S. Tsirkin, 2015/10/08
- [Qemu-devel] [PULL 01/25] configure: probe for memfd, Michael S. Tsirkin, 2015/10/08
- [Qemu-devel] [PULL 04/25] util: add memfd helpers, Michael S. Tsirkin, 2015/10/08
- [Qemu-devel] [PULL 05/25] util: add fallback for qemu_memfd_alloc(), Michael S. Tsirkin, 2015/10/08
- [Qemu-devel] [PULL 06/25] vhost: document log resizing, Michael S. Tsirkin, 2015/10/08
- [Qemu-devel] [PULL 07/25] vhost: add vhost_set_log_base op, Michael S. Tsirkin, 2015/10/08
- [Qemu-devel] [PULL 03/25] util: add linux-only memfd fallback, Michael S. Tsirkin, 2015/10/08
- [Qemu-devel] [PULL 09/25] vhost: alloc shareable log, Michael S. Tsirkin, 2015/10/08
- [Qemu-devel] [PULL 10/25] vhost-user: send log shm fd along with log_base, Michael S. Tsirkin, 2015/10/08
- [Qemu-devel] [PULL 13/25] vhost-user: document migration log, Michael S. Tsirkin, 2015/10/08
- [Qemu-devel] [PULL 14/25] net: add trace_vhost_user_event,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL 15/25] vhost user: add support of live migration, Michael S. Tsirkin, 2015/10/08
- [Qemu-devel] [PULL 20/25] vhost-user-test: remove useless static check, Michael S. Tsirkin, 2015/10/08
- [Qemu-devel] [PULL 21/25] vhost-user-test: wrap server in TestServer struct, Michael S. Tsirkin, 2015/10/08
- [Qemu-devel] [PULL 24/25] vhost-user-test: check ownership during migration, Michael S. Tsirkin, 2015/10/08
- [Qemu-devel] [PULL 22/25] vhost-user-test: learn to tweak various qemu arguments, Michael S. Tsirkin, 2015/10/08
- [Qemu-devel] [PULL 25/25] intel_iommu: Add support for translation for devices behind bridges, Michael S. Tsirkin, 2015/10/08
- [Qemu-devel] [PULL 11/25] vhost-user: add a migration blocker, Michael S. Tsirkin, 2015/10/09
- [Qemu-devel] [PULL 08/25] vhost-user: add vhost_user_requires_shm_log(), Michael S. Tsirkin, 2015/10/09
- [Qemu-devel] [PULL 23/25] vhost-user-test: add live-migration test, Michael S. Tsirkin, 2015/10/09
- [Qemu-devel] [PULL 18/25] vhost: add migration block if memfd failed, Michael S. Tsirkin, 2015/10/09