[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6] linux-user/syscall.c: malloc()/calloc() to g
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v6] linux-user/syscall.c: malloc()/calloc() to g_malloc()/g_try_malloc()/g_new0() |
Date: |
Thu, 8 Oct 2015 10:54:04 +0100 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Tue, Oct 06, 2015 at 09:47:12PM +0530, Harmandeep Kaur wrote:
> Convert malloc()/ calloc() calls to g_malloc()/ g_try_malloc()/ g_new0()
>
> All heap memory allocation should go through glib so that we can take
> advantage of a single memory allocator and its debugging/tracing features.
>
> Signed-off-by: Harmandeep Kaur <address@hidden>
> ---
> v1->v2 convert the free() call in host_to_target_semarray()
> to g_free() and calls g_try_malloc(count) instead of
> g_try_malloc(sizeof(count))
>
> v2->v3 used g_try_new() and friends to avoid overflow issues
>
> v3->v4 use g_free for unlock_iovec() and host_to_target_semarray().
>
> v4->v5 one missing malloc() is converted and one converted is fixed.
>
> v5->v6 new improved commit description.
>
> ---
> linux-user/syscall.c | 28 ++++++++++++++--------------
> 1 file changed, 14 insertions(+), 14 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>