[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 14/16] blockjob: Store device name at job cre
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v2 14/16] blockjob: Store device name at job creation |
Date: |
Fri, 2 Oct 2015 19:44:19 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 01.10.2015 15:13, Kevin Wolf wrote:
> Some block jobs change the block device graph on completion. This means
> that the device that owns the job and originally was addressed with its
> device name may no longer be what the corresponding BlockBackend points
> to.
>
> Previously, the effects of bdrv_swap() ensured that the job was (at
> least partially) transferred to the target image. Events that contain
> the device name could still use bdrv_get_device_name(job->bs) and get
> the same result.
>
> After removing bdrv_swap(), this won't work any more. Instead, save the
> device name at job creation and use that copy for QMP events and
> anything else identifying the job.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/mirror.c | 3 +--
> blockjob.c | 15 ++++++++-------
> include/block/blockjob.h | 8 ++++++++
> 3 files changed, 17 insertions(+), 9 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v2 07/16] block: Convert bs->backing_hd to BdrvChild, (continued)
- [Qemu-devel] [PATCH v2 09/16] block: Split bdrv_move_feature_fields(), Kevin Wolf, 2015/10/08
- [Qemu-devel] [PATCH v2 02/16] vmdk: Use BdrvChild instead of BDS for references to extents, Kevin Wolf, 2015/10/08
- [Qemu-devel] [PATCH v2 04/16] quorum: Convert to BdrvChild, Kevin Wolf, 2015/10/08
- [Qemu-devel] [PATCH v2 01/16] block: Introduce BDS.file_child, Kevin Wolf, 2015/10/08
- [Qemu-devel] [PATCH v2 12/16] block: Introduce parents list, Kevin Wolf, 2015/10/08
- [Qemu-devel] [PATCH v2 14/16] blockjob: Store device name at job creation, Kevin Wolf, 2015/10/08
- [Qemu-devel] [PATCH v2 10/16] block/io: Make bdrv_requests_pending() public, Kevin Wolf, 2015/10/08
- [Qemu-devel] [PATCH v2 05/16] block: Convert bs->file to BdrvChild, Kevin Wolf, 2015/10/08
- Re: [Qemu-devel] [PATCH v2 00/16] block: Get rid of bdrv_swap(), Fam Zheng, 2015/10/09
- Re: [Qemu-devel] [PATCH v2 00/16] block: Get rid of bdrv_swap(), Stefan Hajnoczi, 2015/10/10