|
| From: | Markus Armbruster |
| Subject: | Re: [Qemu-devel] [PATCH 2/3] hw: do not pass NULL to memory_region_init from instance_init |
| Date: | Wed, 30 Sep 2015 10:57:12 +0200 |
| User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Paolo Bonzini <address@hidden> writes: > This causes the region to outlive the object, because it attaches the > region to /machine. This is not nice for the "realize" method, but > much worse for "instance_init" because it can cause dangling pointers > after a simple object_new/object_unref pair. > > Reported-by: Markus Armbruster <address@hidden> > Signed-off-by: Paolo Bonzini <address@hidden> One more: pxa2xx_pcmcia_initfn(). The ones you fix are Tested-by: Markus Armbruster <address@hidden>
| [Prev in Thread] | Current Thread | [Next in Thread] |