Re: [Qemu-devel] [PATCH v2] Remove macros IO_READ_PROTO and IO_WRITE_PROTO

[Stefan Hajnoczi]

On Tue, Oct 6, 2015 at 6:42 PM, Nutan Shinde <address@hidden> wrote:
> Signed-off-by: Nutan Shinde <address@hidden>
> ---
>  hw/audio/adlib.c  | 28 +++++++++++------------
>  hw/audio/es1370.c | 60 +++++++++++++++++++++++++-------------------------
>  hw/audio/gus.c    | 26 +++++++++++-----------
>  hw/audio/sb16.c   | 66 
> +++++++++++++++++++++++++++----------------------------
>  4 files changed, 90 insertions(+), 90 deletions(-)

This patch appears to contain only formatting changes.  From
http://qemu-project.org/Contribute/SubmitAPatch:

"Don't include irrelevant changes. In particular, don't include
formatting, coding style or whitespace changes to bits of code that
would otherwise not be touched by the patch. (It's OK to fix coding
style issues in the immediate area (few lines) of the lines you're
changing.) If you think a section of code really does need a reindent
or other large-scale style fix, submit this as a separate patch which
makes no semantic changes; don't put it in the same patch as your bug
fix."

Patches that update coding style (e.g. whitespace) are usually not
desirable because it introduces churn.  For example, backporting
important fixes becomes harder because the code has changed.

Updating coding style on lines touched in a normal patch is good.
Updating entire files just to update coding style is usually not done
in QEMU.

Stefan