[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 24/26] tcg: Allocate a guard page after code_
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH v4 24/26] tcg: Allocate a guard page after code_gen_buffer |
Date: |
Wed, 30 Sep 2015 18:33:55 +0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On 2015-09-30 15:09, Richard Henderson wrote:
> This will catch any overflow of the buffer.
>
> Add a native win32 alternative for alloc_code_gen_buffer;
> remove the malloc alternative.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> translate-all.c | 210
> ++++++++++++++++++++++++++++++++------------------------
> 1 file changed, 119 insertions(+), 91 deletions(-)
I havent reviewed the patch in details, but I wonder if that could really
happen? Given the size of the code generation buffer (a few MB at
least), I don't think it's a problem if we don't use it to the last kB,
and thus we could keep some safe margin if needed.
Also what happens if an overflow really happens? In softmmu mode a
segmentation fault will happen. In user-mode I guess the fault will
be forwarded to the guest process, so this will likely wrongly
be interpreted as a bug in the guest code.
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
address@hidden http://www.aurel32.net
- [Qemu-devel] [PATCH v4 20/26] tcg: Save insn data and use it in cpu_restore_state_from_tb, (continued)
- [Qemu-devel] [PATCH v4 20/26] tcg: Save insn data and use it in cpu_restore_state_from_tb, Richard Henderson, 2015/10/08
- [Qemu-devel] [PATCH v4 18/26] tcg: Add TCG_MAX_INSNS, Richard Henderson, 2015/10/08
- [Qemu-devel] [PATCH v4 22/26] tcg: Remove tcg_gen_code_search_pc, Richard Henderson, 2015/10/08
- Re: [Qemu-devel] [PATCH v4 00/26] Do away with TB retranslation, Aurelien Jarno, 2015/10/08
- [Qemu-devel] [PATCH v4 03/26] target-*: Increment num_insns immediately after tcg_gen_insn_start, Richard Henderson, 2015/10/08
- [Qemu-devel] [PATCH v4 05/26] tcg: Allow extra data to be attached to insn_start, Richard Henderson, 2015/10/08
- [Qemu-devel] [PATCH v4 06/26] target-arm: Add condexec state to insn_start, Richard Henderson, 2015/10/08
- [Qemu-devel] [PATCH v4 08/26] target-mips: Add delayed branch state to insn_start, Richard Henderson, 2015/10/08
- [Qemu-devel] [PATCH v4 11/26] target-cris: Mirror gen_opc_pc into insn_start, Richard Henderson, 2015/10/08
- [Qemu-devel] [PATCH v4 24/26] tcg: Allocate a guard page after code_gen_buffer, Richard Henderson, 2015/10/08
- Re: [Qemu-devel] [PATCH v4 24/26] tcg: Allocate a guard page after code_gen_buffer,
Aurelien Jarno <=
- [Qemu-devel] [PATCH v4 15/26] target-sparc: Add npc state to insn_start, Richard Henderson, 2015/10/08
- [Qemu-devel] [PATCH v4 21/26] tcg: Remove gen_intermediate_code_pc, Richard Henderson, 2015/10/08