[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] checkpatch: adapt some tests to QEMU
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] checkpatch: adapt some tests to QEMU |
Date: |
Mon, 5 Oct 2015 15:11:13 -0300 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Sun, Oct 04, 2015 at 07:44:29PM +0100, Peter Maydell wrote:
> On 17 September 2015 at 17:32, Paolo Bonzini <address@hidden> wrote:
> >
> >
> > On 17/09/2015 18:16, Peter Maydell wrote:
> >> On 17 September 2015 at 17:00, Paolo Bonzini <address@hidden> wrote:
> >>>
> >>>
> >>> On 17/09/2015 16:24, Peter Maydell wrote:
> >>>> Can we revert this one, please? Checkpatch now warns about constructs
> >>>> like
> >>>> typedef struct MyDevice {
> >>>> DeviceState parent;
> >>>>
> >>>> int reg0, reg1, reg2;
> >>>> } MyDevice;
>
> > I think it varies depending on the maintainer. PPC, USB, SCSI, ACPI all
> > use a separate typedef. I'll prepare a revert.
>
> Ping on that revert patch? I can't find it onlist...
The x86 pull request I sent today triggers this error, BTW. I hope it
won't make the pull request be automatically rejected.
--
Eduardo