|
From: | Yuri Pudgorodskiy |
Subject: | Re: [Qemu-devel] [PATCH 3/5] qga: guest exec functionality |
Date: | Mon, 5 Oct 2015 17:18:36 +0300 |
User-agent: | Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 10/2/2015 1:59 AM, Michael Roth wrote:
+# +# Since: 2.5 +## +{ 'command': 'guest-exec', + 'data': { 'path': 'str', '*arg': ['str'], '*env': ['str'], + '*inp-data': 'str', '*capture-output': 'bool' }, + 'returns': 'GuestExec' }Would it make sense to just add handle (pid) to GuestExecStatus, and have this return GuestExecStatus just the same as guest-exec-status does? I'm not sure either way personally, just thought I'd mention it.
I do not think it's a good idea. GuestExecStatus contains mostly the data about
the finished exec. Having GuestExec returns same struct may make wrongassumption that it can be synchronous - wait for exec to complete and return all
data in a single call. Implementing synchronous GuestExec is not and easy job - either we occupyhost-guest channel for all time until task finished, which is bad or we need to
implement multiplexed messages for concurrent qga commands.
[Prev in Thread] | Current Thread | [Next in Thread] |