[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 22/48] ivshmem: use common is_power_of_2()
From: |
marcandre . lureau |
Subject: |
[Qemu-devel] [PATCH v5 22/48] ivshmem: use common is_power_of_2() |
Date: |
Fri, 2 Oct 2015 21:09:25 +0200 |
From: Marc-André Lureau <address@hidden>
The common version correctly checks for 0 value case.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Claudio Fontana <address@hidden>
---
hw/misc/ivshmem.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index fbb6f40..e678b18 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -117,10 +117,6 @@ static inline uint32_t ivshmem_has_feature(IVShmemState
*ivs,
return (ivs->features & (1 << feature));
}
-static inline bool is_power_of_two(uint64_t x) {
- return (x & (x - 1)) == 0;
-}
-
/* accessing registers - based on rtl8139 */
static void ivshmem_update_irq(IVShmemState *s)
{
@@ -632,7 +628,7 @@ static uint64_t ivshmem_get_size(IVShmemState * s, Error
**errp) {
}
/* BARs must be a power of 2 */
- if (!is_power_of_two(value)) {
+ if (!is_power_of_2(value)) {
error_setg(errp, "size must be power of 2");
return 0;
}
--
2.4.3
- [Qemu-devel] [PATCH v5 00/48] ivshmem improvements, marcandre . lureau, 2015/10/08
- [Qemu-devel] [PATCH v5 02/48] msix: add VMSTATE_MSIX_TEST, marcandre . lureau, 2015/10/08
- [Qemu-devel] [PATCH v5 22/48] ivshmem: use common is_power_of_2(),
marcandre . lureau <=
- [Qemu-devel] [PATCH v5 11/48] ivshmem: limit maximum number of peers to G_MAXUINT16, marcandre . lureau, 2015/10/08
- [Qemu-devel] [PATCH v5 23/48] ivshmem: migrate with VMStateDescription, marcandre . lureau, 2015/10/08
- [Qemu-devel] [PATCH v5 17/48] ivshmem: improve debug messages, marcandre . lureau, 2015/10/08
- [Qemu-devel] [PATCH v5 26/48] ivshmem: add device description, marcandre . lureau, 2015/10/08
- [Qemu-devel] [PATCH v5 34/48] ivshmem-server: fix hugetlbfs support, marcandre . lureau, 2015/10/08
- [Qemu-devel] [PATCH v5 24/48] ivshmem: shmfd can be 0, marcandre . lureau, 2015/10/08
- [Qemu-devel] [PATCH v5 29/48] ivshmem: error on too many eventfd received, marcandre . lureau, 2015/10/08
- [Qemu-devel] [PATCH v5 33/48] ivshmem-server: use a uint16 for client ID, marcandre . lureau, 2015/10/08
- [Qemu-devel] [PATCH v5 31/48] contrib: add ivshmem client and server, marcandre . lureau, 2015/10/08