Re: [Qemu-devel] [PATCH v4 04/26] target-*: Introduce and use cpu_breakpoint_test

[Aurelien Jarno]

On 2015-09-30 15:09, Richard Henderson wrote:
> Reduce the boilerplate required for each target.  At the same time,
> move the test for breakpoint after calling tcg_gen_insn_start.
> 
> Note that arm and aarch64 do not use cpu_breakpoint_test, but still
> move the inline test down after tcg_gen_insn_start.
> 
> Reviewed-by: Peter Maydell <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  include/qom/cpu.h             | 16 ++++++++++++++++
>  target-alpha/translate.c      | 13 ++++---------
>  target-arm/translate-a64.c    | 26 +++++++++++++-------------
>  target-arm/translate.c        | 31 ++++++++++++++++---------------
>  target-cris/translate.c       | 27 ++++++++-------------------
>  target-i386/translate.c       | 17 +++++++----------
>  target-lm32/translate.c       | 25 +++++++------------------
>  target-m68k/translate.c       | 18 ++++++------------
>  target-microblaze/translate.c | 36 +++++++++++++-----------------------
>  target-mips/translate.c       | 25 ++++++++++---------------
>  target-moxie/translate.c      | 19 +++++++------------
>  target-openrisc/translate.c   | 24 +++++++-----------------
>  target-ppc/translate.c        | 14 +++++---------
>  target-s390x/translate.c      | 16 ++++++----------
>  target-sh4/translate.c        | 20 ++++++++------------
>  target-sparc/translate.c      | 23 ++++++++++-------------
>  target-unicore32/translate.c  | 24 ++++++++++--------------
>  target-xtensa/translate.c     | 25 +++++++------------------
>  18 files changed, 160 insertions(+), 239 deletions(-)

Reviewed-by: Aurelien Jarno <address@hidden>

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
address@hidden                 http://www.aurel32.net