[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties aga
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices |
Date: |
Mon, 28 Sep 2015 16:25:23 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 28/09/2015 16:17, Markus Armbruster wrote:
>> The reason why this particular call has a NULL owner is that the
>> (non-qdevified) DBDMA_init object inside it is also passing a NULL
>> owner. DBDMA_init object is also doing a few more non-idempotent things
>> such as a malloc, a vmstate_register and a qemu_register_reset.
I missed a step here: "... thus macio really
cannot_be_created_even_by_object_new_yet".
> * hw/misc/omap_gpmc.c omap_gpmc_cs_map()
>
> Is this sane? I guess the object_unparent() in omap_gpmc_cs_unmap()
> could make it sane.
>
> * hw/ppc/ppc4xx_devs.c sdram_set_bcr()
>
> Is this sane? I guess the object_unparent() there could make it sane.
Yes and yes.
There are many more similar places that you missed, which call
memory_region_init_alias(), memory_region_init_io() and
memory_region_init_ram(). Those are the same.
Paolo
- Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices, (continued)
- Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices, Eduardo Habkost, 2015/09/24
- Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices, Thomas Huth, 2015/09/25
- Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices, Markus Armbruster, 2015/09/25
- Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices, Thomas Huth, 2015/09/25
- Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices, Markus Armbruster, 2015/09/28
- Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices, Andreas Färber, 2015/09/28
- Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices, Paolo Bonzini, 2015/09/28
- Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices, Paolo Bonzini, 2015/09/28
- Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices, Markus Armbruster, 2015/09/29
- Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices, Thomas Huth, 2015/09/28
- Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices, Peter Maydell, 2015/09/28
- Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices, Markus Armbruster, 2015/09/29
- Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices, Peter Maydell, 2015/09/29
- Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices, Markus Armbruster, 2015/09/29
- Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices, Peter Maydell, 2015/09/29