[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] linux-user: Exit 0 when -h is used
From: |
Riku Voipio |
Subject: |
Re: [Qemu-devel] [PATCH 1/4] linux-user: Exit 0 when -h is used |
Date: |
Mon, 28 Sep 2015 16:22:37 +0300 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Mon, Jul 13, 2015 at 01:08:02PM -0700, Meador Inge wrote:
> On Mon, Jul 06, 2015 at 09:43:20PM +0200, Laurent Vivier wrote:
>
> > Global comment: you should use EXIT_SUCCESS and EXIT_FAILURE from stdlib.h
> On second thought, I was following an existing pattern in 'main.c'. Really
> fixing this would require changing around 30 other locations too. I think
> if we are going to switch to the EXIT_* macros, then the whole file should
> be changed in one patch and making that fix shouldn't hold this patch up.
I've just done a commit to for wholesale transition. This code is
only ever compiled for Linux, so portability doesn't matter. I think
it makes the code a bit more self-documenting.
Riku
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 1/4] linux-user: Exit 0 when -h is used,
Riku Voipio <=