[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] target-xtensa: xtfpga: attach FLASH to syst
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] target-xtensa: xtfpga: attach FLASH to system IO |
Date: |
Sun, 27 Sep 2015 11:36:05 -0700 |
On Sun, Sep 27, 2015 at 11:01 AM, Max Filippov <address@hidden> wrote:
> On Sun, Sep 27, 2015 at 8:42 PM, Peter Crosthwaite
> <address@hidden> wrote:
>> On Sun, Sep 27, 2015 at 10:16 AM, Max Filippov <address@hidden> wrote:
>>> XTFPGA FLASH is tied to XTFPGA system IO block. It's not very important
>>> for systems with MMU where system IO block is visible at single
>>> location,
>>
>> Are your relying on a matching change in the guest for MMU setup here?
>>
>> Can you explain a little more how the MMU allows a physical address
>> remap of the underlying hardware as this looks like a non
>> backwards-compatible board design rev.
>
> No change is needed as this change doesn't affect memory map.
> It only detaches FLASH from the system memory and attaches it
> to the system IO region, at the same physical address as before.
>
Ok I get it now :). Commit message confused me a little with the MMU
stuff but reading it again it makes sense. Change looks good. I'll
wait for resolution on P1 before putting an RB.
Regards,
Peter
> --
> Thanks.
> -- Max
[Qemu-devel] [PATCH 3/3] target-xtensa: xtfpga: support noMMU cores, Max Filippov, 2015/09/27