Re: [Qemu-devel] [PATCH 15/36] monitor: register gen:false commands manually

[Eric Blake]

On 09/25/2015 08:03 AM, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
> 
> Since some commands are using 'gen': false, they are not registered
> automatically by the generator. Register manually instead.
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  monitor.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/monitor.c b/monitor.c
> index 410c3a5..a979924 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -945,6 +945,16 @@ static void qmp_query_qmp_schema(QDict *qdict, QObject 
> **ret_data,
>      *ret_data = qobject_from_json(qmp_schema_json);
>  }
>  
> +static void qmp_init_marshal(void)
> +{
> +    qmp_register_command("query-qmp-schema", qmp_query_qmp_schema,
> +                         QCO_NO_OPTIONS);
> +    qmp_register_command("device_add", qmp_device_add,
> +                         QCO_NO_OPTIONS);
> +}

device_add wasn't even mentioned in a *.json file before your series.

/me goes and looks

Oh, you sneakily added it in "qapi: move examples to json schema".
Please separate that into its own patch, as it is more than just moving
examples.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature