qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 4/7] tests: Add QOM property unit tests


From: Daniel P. Berrange
Subject: Re: [Qemu-devel] [PATCH 4/7] tests: Add QOM property unit tests
Date: Fri, 25 Sep 2015 16:01:36 +0100
User-agent: Mutt/1.5.23 (2014-03-12)

On Fri, Sep 25, 2015 at 02:39:45PM +0200, Andreas Färber wrote:
> Add a test for parsing and setting a uint64 property.
> 
> Signed-off-by: Andreas Färber <address@hidden>
> ---
>  MAINTAINERS             |   1 +
>  tests/Makefile          |   3 ++
>  tests/check-qom-props.c | 120 
> ++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 124 insertions(+)
>  create mode 100644 tests/check-qom-props.c

FWIW, back in commit a31bdae5a76ecc060c1eb8a66be1896072c1e8b2 I added
a  check-qom-proplist.c unit test, and later extended it with test
for enums. Perhaps your addition is best placed in there, or we could
rename that test to check-qom-props.c so we just have one file for all
property unit testing

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|



reply via email to

[Prev in Thread] Current Thread [Next in Thread]